Skip to content

Commit 87248d7

Browse files
authored
fix: exclude samples from Maven Central publishing (#3537)
* fix: exclude the Kotlin sample from Maven Central publishing The module has no Java sources, so maven-javadoc-plugin attaches no javadoc jar to it and Central rejects the whole deployment with "Javadocs must be provided but not found in entries", which is what broke the 5.5.1 release. It only exists as a Kotlin interop E2E test, so keep it out of the published bundle. * fix: exclude all samples from Maven Central publishing Replaces the skipPublishing property on the Kotlin sample with an excludeArtifacts list on central-publishing-maven-plugin, so the exclusion lives next to the publishing configuration, and extends it to every sample module: they are demos and end-to-end tests, not artifacts to depend on.
1 parent 574718b commit 87248d7

1 file changed

Lines changed: 14 additions & 0 deletions

File tree

pom.xml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -642,6 +642,20 @@
642642
<tokenAuth>true</tokenAuth>
643643
<autoPublish>true</autoPublish>
644644
<waitUntil>published</waitUntil>
645+
<!-- The samples are demos and end-to-end tests, not artifacts to depend on, so they
646+
are not published. The Kotlin one could not be published anyway: it has no Java
647+
sources, so no javadoc jar is attached to it and Central rejects the whole
648+
deployment with "Javadocs must be provided but not found in entries". -->
649+
<excludeArtifacts>
650+
<excludeArtifact>sample-operators</excludeArtifact>
651+
<excludeArtifact>sample-controller-namespace-deletion</excludeArtifact>
652+
<excludeArtifact>sample-kotlin-operator</excludeArtifact>
653+
<excludeArtifact>sample-leader-election</excludeArtifact>
654+
<excludeArtifact>sample-mysql-schema-operator</excludeArtifact>
655+
<excludeArtifact>sample-operations</excludeArtifact>
656+
<excludeArtifact>sample-tomcat-operator</excludeArtifact>
657+
<excludeArtifact>sample-webpage-operator</excludeArtifact>
658+
</excludeArtifacts>
645659
</configuration>
646660
</plugin>
647661
</plugins>

0 commit comments

Comments
 (0)