Skip to content

Automatic deletion mechanism is broken #26

Description

@Kogerro

Automatic deletion mechanism of old logs is broken. It is based on incorrect assumption, that each log line should start with a time stamp like 2017-10-05T14:46:36.541Z, and chooses logs to delete by simple string comparison of whole log line and string made from date before which logs should be deleted.

This causes two major problems:

  • if there's no such time stamp, old logs won't be ever automatically deleted
  • logs starting with strings "lower" than string made from date before which logs should be deleted are automatically deleted.

It took me a long search to find why all my logs starting with custom date "dd/mm" are removed between Hyperlog initializations - it was simply because it made log lines start with '0', while string made from date before which logs should be deleted always started with '2'.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions