Skip to content

Remove dead guards from container_traits.hpp #587

Description

@samkelemen

Before filing

  • I searched the existing issues and did not find a duplicate.
  • This is a concrete proposal, not an open-ended design question.

Kind of addition

  • New algorithm
  • New data structure
  • New property map or utility
  • New I/O format reader or writer
  • Extension to an existing component
  • Performance improvement
  • Other (specify below)
    Remove BOOST_CXX11* guards from include/boost/pending/container_traits.hpp

Motivation

There are many guards in the codebase left from before the library required C++14. The motivation is to clean up this one file of the code base to no longer have these dead guards.

Proposed addition

The following guards will be removed from container_traits.hpp:

  • #ifndef BOOST_NO_CXX11_HDR_UNORDERED_SET
  • #ifndef BOOST_NO_CXX11_HDR_UNORDERED_MAP
  • #ifdef BOOST_NO_CXX11_RVALUE_REFERENCES

Relation to existing Boost.Graph components

This change has no impact on the code, as the guards are dead code with C++14 or greater.

Prior art

  • Reference paper or textbook (cite below)
  • Implementation in another library (link below)
  • None / original idea

References:

Are you willing to contribute?

  • I'd like to submit the implementation as a pull request.
  • I can help with review or testing, but not the implementation.
  • I'm only proposing the idea.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

technical debtCode that works but needs refactoring, cleanup, or modernization. Not user-facing.

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions