Skip to content
This repository was archived by the owner on Jun 2, 2023. It is now read-only.
This repository was archived by the owner on Jun 2, 2023. It is now read-only.

linalg method of gw loss gives erroneous values with pytorch #172

Description

@janetrbarclay

Using the linear algebra calculation approach for the groundwater loss in pytorch gives values 2 to 10 times higher than the loss values using the fft calculation within pytorch, the fft calculation within tf and the linear algebra calculation within tf (these three are the same).

We've added an assertion that requires the fft method when the gw loss is used within pytorch. We are not debugging the linear algebra code, but are leaving it for now in case it is needed in the future.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions